powered by Jive Software

Another Group.java bugs?

Hi there,

I thinks that implementation of the MemberCollection wrapper class in Group.java has a few problems:

  1. Access to members collection needs to be synchronized.

  2. There is overridden add method implemented but there is no remove override.

  3. Checking that user already belongs to a group should be done against bare JID and not against full JID (that includes resource) as it is done currently.

I have modified version of the Group.java where these issues are fixed. Iā€™'ll be happy to post it if needed.

Thanks,

Eugene.

Hey Eugene,

Could you send me your modified file so I can review it? You can send it to gaston at jivesoftware.com.

Thanks,

ā€“ Gato

Hey Gato,

I sent it to you.

Eugene.