Bug - Hazelcast plugin (OF 4.2.1) Null Pointer Exception in ClusterListener.cleanupNode

dbh · January 25, 2018, 4:36am

There is a bug in the Hazelcast plugin (OF 4.2.1) which causes a null pointer exception, when ClusterListener’s cleanupNode is called. The problem seems to happen if a hazelcast node in the cluster is getting shutdown / goes offline, but there are no sessions connected to it. The code makes the assumption that whatever nodeRoutes.get(…) returned is non-null, but that isn’t the case when there were no sessions associated with the node.

See ClusterListener.java, cleanupNode, Line 282 and Line 282.
Please create a JIRA if appropriate. I may have some free time to try and fix this one.

github.com

igniterealtime/Openfire/blob/v4.2.1/src/plugins/hazelcast/src/java/org/jivesoftware/openfire/plugin/util/cache/ClusterListener.java#L282




Set<String> anonymousUsers = lookupJIDList(key, anonymousC2SCache.getName());
if (!anonymousUsers.isEmpty()) {
    for (String fullJID : new ArrayList<String>(anonymousUsers)) {
        JID offlineJID = new JID(fullJID);
        manager.removeSession(null, offlineJID, true, true);
    }
}


// Remove outgoing server sessions hosted in node that left the cluster
Set<DomainPair> remoteServers = nodeRoutes.get(key);
if (!remoteServers.isEmpty()) {
    for (DomainPair domainPair : remoteServers) {
        routingTable.removeServerRoute(domainPair);
    }
}
nodeRoutes.remove(key);


Set<String> components = lookupJIDList(key, componentsCache.getName());
if (!components.isEmpty()) {
    for (String address : new ArrayList<String>(components)) {

wroot · January 25, 2018, 5:16am

https://issues.igniterealtime.org/browse/OF-1467

dbh · January 26, 2018, 5:34am

Pull request submitted for OF-1467