powered by Jive Software

BUG: Message.as::deserialize() ignores some stanzas

While trying to implement proper HTML body payloads today, I found this one.

If a message comes in that contains a chatstate, any incoming child nodes that should be processes subsequent are ignored.

case Message.STATE_ACTIVE :
case Message.STATE_COMPOSING :
case Message.STATE_GONE :
case Message.STATE_INACTIVE :
case Message.STATE_PAUSED :
myStateNode = children[i];
break;

Should be:

case Message.STATE_ACTIVE :
case Message.STATE_COMPOSING :
case Message.STATE_GONE :
case Message.STATE_INACTIVE :
case Message.STATE_PAUSED :
myStateNode = children[i];
continue;

I’ve not included a patch here because my local Message.as is substantially different than the version in the trunk and my changes have not been accepted pending outcome of this thread: http://www.igniterealtime.org/community/thread/40815?tstart=0

Such a change does not even require a patch as it is simply a replace of a word, where the word is easily founded.

I will test this as soon as possible and commit a fix.