Bug - Openfire Admin Show Sessions problem (Hazelcast + Openfire 4.2.x)

dbh · December 18, 2017, 7:59pm

Currently, I have found an issues in the Openfire admin screen, show current sessions tab, results in a casting exception.

It works correctly when Hazlecast is disabled/turned off. It failed with a casting exception when Hazlecast is enabled with more than 1 node. The problem seems to have been introduced in 4.2.0 final

The offending line appears to be in session-row.jspf, where it makes an assumption that the session is of the type LocalClientSession and does a cast. This however fails in the clustered scenario, as not all sessions are Local.

github.com

igniterealtime/Openfire/blob/dcef698f85eb09c46a7ca3865d6f105610909ba5/src/web/session-row.jspf#L172


    </td>


<%  } %>


<td width="1%" nowrap>
    <%= sess.getPresence().getPriority() %>
</td>


<td width="1%" nowrap>
    <%
        LocalClientSession localSession = (LocalClientSession) sess;
        if (localSession != null && localSession.isDetached()) { %>
            <fmt:message key="session.details.sm-detached"/>
        <% } else {
            try { %>
            <%= sess.getHostAddress() %>
        <% } catch (java.net.UnknownHostException e) { %>
            Invalid session/connection
        <% }
        } %>
</td>

LocalClientSession localSession = (LocalClientSession) sess;
if (localSession != null && localSession.isDetached()) { %>

Error Message displayed in Sessions view

java.lang.ClassCastException: org.jivesoftware.openfire.plugin.session.RemoteClientSession cannot be cast to org.jivesoftware.openfire.session.LocalClientSession
	at org.jivesoftware.openfire.admin.session_002dsummary_jsp._jspService(session_002dsummary_jsp.java:536)
	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)

akrherz · December 18, 2017, 8:11pm

Please provide the NPE

dbh · December 29, 2017, 12:02am

Thank you. I added details above to original post. Exception was not an NPE but rather Casting exception.

akrherz · January 3, 2018, 2:01pm

Thank you, OF-1460 has been filed and I alerted @dwd to the issue.

dbh · January 24, 2018, 3:16pm

For anyone following this thread, OF-1460 is now fixed in the master branch .