powered by Jive Software

JingleSession state

Hi every boy,

Perhaps my previous post (http://www.igniterealtime.org/forum/thread.jspa?threadID=27430&tstart=0) was too confusing.

Much simpler : is there a good reason for wich an IncomingJingleSession state’'s goes from “null” to “accepting” only after a JingleSession.start() and not directly after an JingleSessionRequest.accept() ?

The problem is that in the first case, it ''s possible to lose incoming packets for a sessin which we have accepted, between the accept() and the start(), because we are not listening for incoming parcket in this stagee.

regards

  • org.jivesoftware.smackx.jingle.IncomingJingleSession.java

— IncomingJingleSession.java 2007-06-21 14:48:30.000000000 +0200

+++ IncomingJingleSession.java.fixed 2007-07-18 18:13:46.109375000 +0200

@@ -130,7 +130,10 @@

if (resolver.getType().equals(TransportResolver.Type.ice)) {

setTransportNeg(new TransportNegotiator.Ice(this, resolver));

}

  •    // Establish the default state
    
  •    setState(accepting);
    
  •    updatePacketListener();
    

}

/**

@@ -155,11 +158,6 @@

  • @throws XMPPException

*/

public void start(JingleSessionRequest initialJingleSessionRequest) throws XMPPException {

  •    // Establish the default state
    
  •    setState(accepting);
    
  •    updatePacketListener();
    

Jingle packet = initialJingleSessionRequest.getJingle();

if (packet != null) {