Mucext plugin allows multiple values with text_single formfield

Openfire Plugins
1

Concerning the mucext plugin: GitHub - igniterealtime/openfire-mucextinfo-plugin: An Openfire plugin that allows an admin to configure Extended Service Discovery information to Multi User Chat entities.

When more or less by accident found out when adding a second muc extension value like so (adding a duplicate creation date):

image
image2015×440 20.5 KB

This will be sent to the client as a text-single with multiple vales:
val1val2

Which then give an error in the smack library:

SEVERE:[12:02:00][org.jivesoftware.smack.parsing.ExceptionLoggingCallback handleUnparsableStanza] Smack message parsing exception. Content: '</x></query></iq>'org.jivesoftware.smack.parsing.SmackParsingException: text-single fields can have at most one value, this one had 2	at org.jivesoftware.smackx.xdata.provider.DataFormProvider.ensureAtMostSingleValue(DataFormProvider.java:450)	at org.jivesoftware.smackx.xdata.provider.DataFormProvider.parseSingleKindFormField(DataFormProvider.java:348)	at org.jivesoftware.smackx.xdata.provider.DataFormProvider.parseField(DataFormProvider.java:306)	at org.jivesoftware.smackx.xdata.provider.DataFormProvider.parseField(DataFormProvider.java:144)	at org.jivesoftware.smackx.xdata.provider.DataFormProvider.parse(DataFormProvider.java:92)

I made a small PR for this to fix it:

2

Thanks Micha! I’ve left some review comments in the pull request.