powered by Jive Software

[patch] Documentation fix for DNSUtil

Dear Smack devs,

here’s another patch - this time to fix the documentation for DNSUtil. It states it would look up _jabber._tcp, but it does not.

Patch is released to public domain, as it is trivial.

Max

Index: source/org/jivesoftware/smack/util/DNSUtil.java

— source/org/jivesoftware/smack/util/DNSUtil.java (revision 11097)
+++ source/org/jivesoftware/smack/util/DNSUtil.java (working copy)
@@ -57,14 +57,12 @@
/**
* Returns the host name and port that the specified XMPP server can be
* reached at for client-to-server communication. A DNS lookup for a SRV

  • * record in the form "_xmpp-client._tcp.example.com" is attempted, according
    
  • * to section 14.4 of RFC 3920. If that lookup fails, a lookup in the older form
    
  • * of "_jabber._tcp.example.com" is attempted since servers that implement an
    
  • * older version of the protocol may be listed using that notation. If that
    
  • * lookup fails as well, it's assumed that the XMPP server lives at the
    
  • * host resolved by a DNS lookup at the specified domain on the default port
    
  • * of 5222.<p>
    
  • *
    
  • * record in the form "_xmpp-client._tcp.example.com" is attempted,
    
  • * according to section 14.4 of RFC 3920. If that lookup fails, it's assumed
    
  • * that the XMPP server lives at the host resolved by a DNS lookup at the
    
  • * specified domain on the default port of 5222.
    
  • * <p>
    
  • *
    * As an example, a lookup for "example.com" may return "im.example.com:5269".
    *
    * Note on SRV record selection.