[PATCH] NPE: XMPPConnection.close

Smack Smack Dev
1

User description: Failed after unsuccessfull try to connect to jabber server

Error message: No message

java.lang.NullPointerException

at org.jivesoftware.smack.XMPPConnection.close(XMPPConnection.java:660)

at org.jivesoftware.smack.PacketReader.notifyConnectionError(PacketReader.java:205 )

at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:384)

at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:43)

at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:63)

Patch:

Index: source/org/jivesoftware/smack/XMPPConnection.java

===================================================================

— source/org/jivesoftware/smack/XMPPConnection.java (revision 4992)

+++ source/org/jivesoftware/smack/XMPPConnection.java (working copy)

@@ -644,12 +644,12 @@

  • the XMPP server. Once a connection has been closed, it cannot be re-opened.

*/

public void close() {

  •    // Set presence to offline.

  •    packetWriter.sendPacket(new Presence(Presence.Type.unavailable));

  •    packetReader.shutdown();

  •    packetWriter.shutdown();

  •    // Wait 150 ms for processes to clean-up, then shutdown.

try {

  •        // Set presence to offline.

  •        packetWriter.sendPacket(new Presence(Presence.Type.unavailable));

  •        packetReader.shutdown();

  •        packetWriter.shutdown();

  •        // Wait 150 ms for processes to clean-up, then shutdown.

Thread.sleep(150);

}

catch (Exception e) {

2

Uhm, your patch doesn’'t change anything? It just replaces some lines with ones with the same content.

3

It moves the lines into try/catch block.

4

oh right, sorrry, didn’'t see that one.