Writing here for some patches we’ve been using, as advised: “report new issues, please post them in the Forum”
We’ve been using smack for our jabber support in Jitsi, for IM, audio and video - calls and conferences. Here are some patches that we have been adding from smack version 3.1. Those patches are against current trunk.
- Patch 1 - discovery-info-escape-nodes.patch
For this one we found a problem where the nodes strings in the discovery info packets are not escaped as in the other packets.
- Patch 2 - memory-leak.patch
This one was recently discovered. Improper use of WeakHashMap leads to memory leak as XMPPConnections stay in memory and all their listeners.
- Patch 3 - xmppconnection.patch
These changes to XMPPConnection are some fixes and features we’ve added and we are currently using:
Setting a custom trust manager, so we can control from outside the certificates, like asking the users with UI dialog do they trust this particular certificate and remember their choice.
Replace a call getInetAddress().getHostName() with getInetAddress().getHostAddress() to avoid unnecessary DNS requests.
Give access to the socket outside the connection. This one is used only for information purposes, to have the local/remote port and local/remote address of the connection in our packet logging utility.
discovery-info-escape-nodes.patch.zip (937 Bytes)
memory-leak.patch.zip (745 Bytes)
xmppconnection.patch.zip (1171 Bytes)