Smack 4.3 BoBManager response to BobIQRequest with incorect StanzaId

Smack Smack Dev
1

BobManager responses to BobIQRequest with incorrect stanza Id as shown in the captured debug log below.
Attached with the proposed patch for the fix:

BobManager.patch (820 Bytes)

Please see: https://issues.igniterealtime.org/browse/SMACK-845

2018-12-11 12:02:24.308 16233-16963/org.atalk.android D/SMACK: RECV (0): <iq xml:lang='en' to='swordfish@atalk.org/atalk' from='leopard@atalk.org/atalk' type='set' id='YOnL9-148'><si xmlns='http://jabber.org/protocol/si' id='jsi_-2079927862' mime-type='image/jpeg' profile='http://jabber.org/protocol/si/profile/file-transfer'><file xmlns='http://jabber.org/protocol/si/profile/file-transfer' name='4fa8ce37-7377-45db-ab12-a7094f33eed1-1.jpg' size='19868'><thumbnail xmlns='urn:xmpp:thumbs:0' cid='sha1+ba64ba624f00e53f2abf3f621af15a0239cc7a8a@bob.xmpp.org' mime-type='image/png' width='64' height='64'/></file><feature xmlns='http://jabber.org/protocol/feature-neg'><x xmlns='jabber:x:data' type='form'><field var='stream-method' type='list-single'><option><value>http://jabber.org/protocol/bytestreams</value></option><option><value>http://jabber.org/protocol/ibb</value></option></field></x></feature></si></iq>
2018-12-11 12:02:24.333 16233-16962/org.atalk.android D/SMACK: SENT (0): <iq to='leopard@atalk.org/atalk' id='LNK1E-180' type='get'><data xmlns='urn:xmpp:bob' cid='sha1+ba64ba624f00e53f2abf3f621af15a0239cc7a8a@bob.xmpp.org'/></iq>
2018-12-11 12:02:34.343 16233-17979/org.atalk.android E/aTalk: [7156] impl.protocol.jabber.IncomingFileTransferRequestJabberImpl.run().232 Could not get thumbnail
    org.jivesoftware.smack.SmackException$NoResponseException: No response received within reply timeout. Timeout was 10000ms (~10s). Waited for response using: IQReplyFilter: iqAndIdFilter (AndFilter: (OrFilter: (IQTypeFilter: type=error, IQTypeFilter: type=result), StanzaIdFilter: id=LNK1E-180)), : fromFilter (OrFilter: (FromMatchesFilter (full): leopard@atalk.org/atalk)).
        at org.jivesoftware.smack.StanzaCollector.nextResultOrThrow(StanzaCollector.java:269)
        at org.jivesoftware.smack.StanzaCollector.nextResultOrThrow(StanzaCollector.java:219)
        at org.jivesoftware.smackx.bob.BoBManager.requestBoB(BoBManager.java:152)
        at net.java.sip.communicator.impl.protocol.jabber.IncomingFileTransferRequestJabberImpl$1.run(IncomingFileTransferRequestJabberImpl.java:226)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:457)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:764)
2018-12-11 12:03:36.916 16233-16963/org.atalk.android D/SMACK: RECV (0): <iq xml:lang='en' to='swordfish@atalk.org/atalk' from='leopard@atalk.org/atalk' type='result' id='YOnL9-150'><data xmlns='urn:xmpp:bob' cid='sha1+ba64ba624f00e53f2abf3f621af15a0239cc7a8a@bob.xmpp.org' type='image/png'>/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH
.....
/2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCABAAEADASIAAhEBAxEB/8QAHwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/Gdj4Eig1LV4be1n0v4j+K9D+M+uaH8Lrr9AP2mP+DVD44eEf2JvjD+318O/irpHwr/AOFY6V+0r8WfiZ+xx8efBPiLw54w+E3wr+BE3xfv9c0Dwf8A
2

I’m confused. Isn’t this just

but with a different Smack version? Any particular reason you create another post about the issue?

3

Sorry. I must have misunderstood your previous comment, requesting me to raise the PR for v4.3.

4

No, I meant that you issue a Github Pull Request (PR) against Smack’s 4.3 branch with a fix for this (your patch basically). I believe it is a good chance to get famililar with git and github (that is, if you want to).

If you don’t want to, then that is also fine. Just tell me, and I’ll do it myself.