When should ROAR notifications be displayed?

The Spark ROAR plugin can be used to have notifications/popups show when messages are being received.

Currently, the ROAR plugin does not show a notification when the room for which the message is received is “showing”. The rationale here probably is that you do not want a popup when a user is looking at the room.

However, I’ve found that I’m not getting notifications when another application is on top of Spark - where I can’t actually see the room.

Should we add some kind of additional criterium (for surpressing the popup) that requires the Spark window to also have focus / be active?

I did a search and there is a bunch of tickets. I even managed to duplicate my own ticket :slight_smile:

This is the older one, but originated from some bugs with skins (maybe not a bug, but just bad test) and then in comment i formulated what you say here https://issues.igniterealtime.org/browse/SPARK-1568

Newer one, again agreeing with your idea https://issues.igniterealtime.org/browse/SPARK-1784
I would probably close old one as a duplicate and leave new one for this.

If it is possible to detect, we should show popups when MUC is not in front/top. Or just show popup for all messages as regular chat does. Although i have a ticket to disable popups for active tab. But i’m not sure about it. I kind of got used to how it works with regular chats and always shows a popup :slight_smile: https://issues.igniterealtime.org/browse/SPARK-1782

I’ve given it a try here: https://github.com/igniterealtime/Spark/pull/500

Closed SPARK-1568 as a duplicate.

I have tested latest change and now it shows a popup if window is up but not active, even if it is fully visible, but maybe you clicked in some other window. It doesn’t show a popup if you are in that window, just sent a message or something. So it seems to be working as intended now :slight_smile: Marking SPARK-1784 as completed.

As about SPARK-1782, it is still the same and i’m not sure about it. If you are chatting with someone and you receive a message in another tab, nickname in a tab turns red, so it is probably enough to get your attention. On the other hand it is handy to see a popup and see what that other person is talking about without even opening that tab. And as nobody complained about this behavior (although, probably just because there are not so many ROAR users), maybe we should leave it as is.

Oh, i was wrong about the last one. https://issues.igniterealtime.org/browse/SPARK-1782 is talking about not showing a popup for the chat tab that is now active and you chatting in it. So essentially you can replicate same change as for the MUC. If you are chatting and window is active, you are seeing new message anyway, so no need to show a popup in such case.

Roar notification with Windows 10 looks cool!

It works correctly with MUC and one on one and when the chat is inactive or closed.
Probably it could be turned on by default with some settings (maximum 4 notifications and 5000ms time), but unfortunately Roar shows a notification even if your chat is active.