powered by Jive Software

XMPPBOSHConnection sendXML patch

XIFF 3 trunk patch for XMPPBOSHConnection
xmppboshconnection-sendXML.patch.zip (514 Bytes)

Great – thanks, I was just working on this myself but you saved me some effort.

Although, XIFF data representation really should be migrated from XMLNode to XML. But this is a rather large undertaking, there are hundreds of references to XMLNode and XMLDocument throughout the code from the base classes all the way to the control logic. Who wants to do it!

Karthik

I should add that I was working on this issue because XMPPBOshConnection was erroring when trying to use SASL-Anonymous:

TypeError: Error #1034: Type Coercion failed: cannot convert XML@5409a41 element <auth mechanism="ANONYMOUS" xmlns="urn:ietf:params:xml:ns:xmpp-sasl"/> to flash.xml.XMLNode. at org.igniterealtime.xiff.core::XMPPBOSHConnection/sendXML()[C:\Documents and Settings\Karthik Kailash\Desktop\karthik\ViewingPartiesRapidPrototype\src\org\igniterealtime\xiff\core\XMPPBOSHConnection.as:273] at org.igniterealtime.xiff.core::XMPPConnection/beginAuthentication()[C:\Documents and Settings\Karthik Kailash\Desktop\karthik\ViewingPartiesRapidPrototype\src\org\igniterealtime\xiff\core\XMPPConnection.as:1142] at org.igniterealtime.xiff.core::XMPPConnection/handleStreamFeatures()[C:\Documents and Settings\Karthik Kailash\Desktop\karthik\ViewingPartiesRapidPrototype\src\org\igniterealtime\xiff\core\XMPPConnection.as:718] at org.igniterealtime.xiff.core::XMPPBOSHConnection/processResponse()[C:\Documents and Settings\Karthik Kailash\Desktop\karthik\ViewingPartiesRapidPrototype\src\org\igniterealtime\xiff\core\XMPPBOSHConnection.as:420] at flash.events::EventDispatcher/dispatchEventFunction() at flash.events::EventDispatcher/dispatchEvent() at flash.utils::Timer/tick()

It happened because the request field in SASLAuth is defined as an XML object with E4X, but all the connection objects are expecting XMLNodes. This patch fixes that.

…I’ve been working on it for some time now…

Don’t know when to finish.

Hi Juga,

If you would like help testing etc. on this, I would love to help out.

If you create a branch for this version of the code I can test my project’s codebase against it. Not sure what the state of the code is, but let me know!

Cheers,

Karthik

If there’s anything we can do to help, let us know.

http://svn.igniterealtime.org/svn/repos/xiff/branches/xml-migration/

Applied.