Bug: group sharing appears enabled by default for LDAP groups (display error)

Hello all,

I have OpenFire set up to use LDAP for users and groups. When viewing a group for the first time in the administration console, the “Contact List (Roster) Sharing” appears “Enabled”, with an empty “Enter contact list group name” field. However, this functionality is not actually active (the group is not shared, and the corresponding properties in the database are not set). I encounter this issue on versions 3.3.3 and 3.4.1 of OpenFire.

This can be worked around by selecting the desired options and clicking “Save Contact List Settings”. From then on, behaviour is as expected.

The cause of this is that when groups are imported from LDAP, no properties are set (sharedRoster.showInRoster is not set in the database). Please find an attached patch for the group-edit.jsp page that restores correct display. This is my suggestion to solve this - is this the right way? If not, please let me know and I will rework this patch.