powered by Jive Software

Bug in ComponentManager.sendPacket

Hi !

ComponentManager.sendPacket should send packets to router, not to deliverer for catch packets like “presence subscribe”. See patch below.

WBR, Alex.

RCS file: /cvs-org/messenger/src/java/org/jivesoftware/messenger/ComponentManager.java,v

retrieving revision 1.6

diff -r1.6 ComponentManager.java

5a6

import org.jivesoftware.messenger.spi.PacketRouterImpl;

115,116c116,117

< PacketDelivererImpl deliverer = (PacketDelivererImpl) ServiceLookupFactory.getLookup().lookup(PacketDelivererImpl.class);

< if (deliverer != null) {


PacketRouter router = (PacketRouterImpl) ServiceLookupFactory.getLookup().lookup(PacketRouterImpl.class);

if (router != null) {

118c119

< deliverer.deliver(packet);


router.route(packet);

122c123

< Log.error(“Unable to deliver packet”, e);


Log.error(“Unable to route packet”, e);

Alex,

Thanks for the patch, we’'ll get this fixed in CVS today.

Regards,

Matt

It has been changed. Thanks Alex