BUG in Group.java

Openfire Openfire Dev
1

Hi,

isUser(JID user) function in Group.java will always return false if resource in JID is not null. The code belongs to 3.2.2 version but I also checked the latest trunk in the SVN. Can it be fixed?

public boolean isUser(JID user) {

return user != null && (members.contains(user) || administrators.contains(user));

}

2

The current method is:

public boolean isUser(JID user) {

return user != null && (members.contains(user) || administrators.contains(user));

}

How is that logic wrong? If the user is null, false will be returned. If the user is not null, the member and admin check will be tried.

Regards,

Matt

3

Hey evgol,

I modified the code so that full JIDs are converted into bare JIDs before the checking is done. Code is now in SVN and will be available in the next nightly build and Openfire 3.3.0 Beta 1.

Thanks,

– Gato

4

Thanks, Gato.