In setup, some of the host settings are loaded from XML properties specified in openfire.xml, while others are incorrectly loaded from whats currently in JiveGlobals. Since we are in setup mode, JiveGlobals.getProperty returns null thereby ignoring any property overrides in openfire.xml specified by the user.
Fixes:
Instead of just blindly setting anonymous auth to true, check if user has an override property in XML configuration, if not, default to true.
Call getXMLProperty to load user configuration override values and not what is currently in JiveGlobals. During setup mode, this is always null.
Instead of setting default values for auth, user, group, card, lockout, securityAudit and admin class names, check if the user has provided overrides for those properties, and if so, use those, otherwise use defaults.
Expose a method to retrieve XML property names, and then in finishSetup, go through the rest of the XML properties overridden by user that were not touched by setup and individually set those. This is particularly useful when users have to specify primary and secondary * hybrid providers.
You are welcome. If everbody sticks to git best practices and common guidelines then we all benefit from a cleaner, better and clearer development process.
Uh and btw, it was not really necessary to close the pull requests (at least the one that was already pulling from a non-master branch). Github allows you to update PRs easily (e.g. by using force push).