Crash on Android with Smack 4.5-rc1 due to malformed XMPP packet

Smack Smack Dev
1

Hi, When receiving an incomplete or malformed XMPP packet, the Android app crashes with:

java.lang.AssertionError
	at org.jivesoftware.smack.util.ParserUtils.assertAtEndTag(ParserUtils.java:67)
	at org.jivesoftware.smack.AbstractXMPPConnection.parseAndProcessStanza(AbstractXMPPConnection.java:1489)
	at org.jivesoftware.smack.tcp.XMPPTCPConnection.access$100(XMPPTCPConnection.java:132)
	at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.parsePackets(XMPPTCPConnection.java:987)
	at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.-$$Nest$mparsePackets(Unknown Source:0)
	at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader$1.run(XMPPTCPConnection.java:952)
	at java.lang.Thread.run(Thread.java:1563)

This happens in weak networks, packet loss, or server-side issues. The library throws an AssertionError, which kills the entire app.

Bad data should be logged and ignored, not crash the client.

Please fix this.
We rely on your library.
Thanks.

2

Which version of Smack is this?

3

4.5-rc1