Issues blocking 2.9.0 release (all resolved)

There used to be a long list of issues in the first message, but thanks to @guus the rest of them were fixed recently. So this thread is done and i will close it as it became quite lengthy :slight_smile:

1 Like

@guus, @speedy, @Alameyo and all others interested in this. As it often comes up in chat and other places, i have compiled a list of issues that i think should be fixed before doing 2.9.0 release.

Thanks for this, Wroot. It is good to put focus on things.

In one of our recent video calls, those that were present there agreed to not go forward with JxBrowser, as we are unwilling to meet some of their licensing-related demands. Instead, we’ll have another stab at JCEF. We’ve found that in @dwd, we have someone that has actual expertise in setting up builds of their code.

I have used

                 <dependency>
			<groupId>org.bitbucket.johness</groupId>
			<artifactId>java-cef</artifactId>
			<version>49.87.win64.2</version>
		</dependency>

in our internal spark build and replaced the fastpath cobrowser, it works well if a little slow to start up.
not sure how well maintained the project is but could be a good starting point

1 Like

All artifacts there are for win, so probably won’t be enough to cover all platforms. Last update was 1 year ago. So, it’s not very active.

As i say a starting point

I think the certificate stuff, the one character message bug, and the toast roar stuff should probably be fixed before a release. The jxbrowers/jcef might take a while to work out, so perhaps we can add that back in with a dot release?

This will probably also mean removal of ofmeet plugin.

Changed first issue to SPARK-1914 Replace JxBrowser with JCEF

you’ll prob hate this suggestion, but should we go ahead and see about upgrading smack to the latest version before trying to push out a release as well? I think flow is getting ready to release 4.3 sometime in the near future.

Feel free to take a stab at it :slight_smile: But i’m not considering it a blocker. More like nice to have https://issues.igniterealtime.org/browse/SPARK-1843

I stabbed at it, and killed it! :skull_and_crossbones: I’m trying to bribed @Paul_Schaub now! :slight_smile:

I agree, not a blocker, but Id hate to see spark get behind by 2 major smack versions.

Added https://issues.igniterealtime.org/browse/SPARK-2065 to the list of blocking issues.

Added Emoticons issue to the list. There is also a minor bug with Roar related to Smack 4.3 update, but it is not a blocker.

Added another major issue (assuming after Smack update) https://issues.igniterealtime.org/browse/SPARK-2069

Taking SPARK-2001 Add a popup for accepting certificate from a connection of the list.

Added an issue with anonymous login to the list

Anonymous login fixed with https://github.com/igniterealtime/Spark/pull/443

Removed SPARK-1887 Shouldn’t show a toast popup for your own message in MUC from the list

Removed from the list SPARK-2043 Not showing one character long messages