Misleading ERROR logged to Linux systemd 'journalctl -xe' output on openfire startup

Gregory_Young · December 6, 2022, 5:22pm

Dec 02 16:27:28 upgrade-test.localdomain openfire[6631]: Starting openfire:
Dec 02 16:27:29 upgrade-test.localdomain postgres[6698]: [8-1] 2022-12-02 21:27:29.627 GMT [6698] ERROR:  relation "jiveversion" does not exist at character 8
Dec 02 16:27:29 upgrade-test.localdomain postgres[6698]: [8-2] 2022-12-02 21:27:29.627 GMT [6698] STATEMENT:  UPDATE jiveVersion SET name='openfire' WHERE name='wildfire'

this ‘ERROR’ is caused by some legacy code in ‘xmppserver/src/main/java/org/jivesoftware/database/SchemaManager.java’ which tries to change the product name from ‘wildfire’ to ‘openfire’.

github.com

igniterealtime/Openfire/blob/6c0a860db2256141a8ef08bf840349df77340ea5/xmppserver/src/main/java/org/jivesoftware/database/SchemaManager.java#L323

      
        
                        }
                    }
                    else {
                        String resourceName = "upgrade/" + upgradeVersion + "/" + schemaKey + "_" +
                                DbConnectionManager.getDatabaseType() + ".sql";
                        resource = resourceLoader.loadResource(resourceName);
                    }
                    return resource;
                }
            
            
    private void updateToOpenfire(Connection con){
                    PreparedStatement pstmt = null;
                    try {
                        pstmt = con.prepareStatement("UPDATE jiveVersion SET name='openfire' WHERE name='wildfire'");
                        pstmt.executeUpdate();
                    }
                    catch (Exception ex) {
            //            Log.warn("Error when trying to update to new name", ex);
                        // This is "scary" to see in the logs and causes more confusion than it's worth at this point.
                        // So silently move on.
                    }

This function just blindly updates the value without checking that the value is currently set to ‘wildfire’ or not, let alone not checking that the ‘jiveversion’ table even exists. I believe at this point in time, the whole function and the call in ‘CheckOpenfireSchema’ can be removed.

github.com

igniterealtime/Openfire/blob/6c0a860db2256141a8ef08bf840349df77340ea5/xmppserver/src/main/java/org/jivesoftware/database/SchemaManager.java#L82

      
        
            
            
/**
             * Checks the Openfire database schema to ensure that it's installed and up to date.
             * If the schema isn't present or up to date, an automatic update will be attempted.
             *
             * @param con a connection to the database.
             * @return true if database schema checked out fine, or was automatically installed
             *      or updated successfully.
             */
            public boolean checkOpenfireSchema(Connection con) {
                // Change 'wildfire' to 'openfire' in ofVersion table (update to new name)
                updateToOpenfire(con);
                try {
                    return checkSchema(con, "openfire", DATABASE_VERSION,
                            new ResourceLoader() {
                                @Override
                                public InputStream loadResource(String resourceName) {
                                    File file = new File(JiveGlobals.getHomeDirectory() + File.separator +
                                            "resources" + File.separator + "database", resourceName);
                                    try {
                                        return new FileInputStream(file);

guus · December 13, 2022, 10:42am

Thanks for reporting this. I’ve created a ticket for this in our issue tracker: [OF-2558] - Ignite Realtime Jira