Pacekt filter i18n

Jorge_Merlino · November 23, 2009, 1:15pm

I have modified the packet filter plugin code to add complete support for i18n. There was some work done but it was far from complete. I`ve also included a spanish translation file.

Here I attach the patch for your consideration.

Best regards
packetFilter.patch.zip (5093 Bytes)

akrherz · November 23, 2009, 1:58pm

Thanks,

I filed this as OF-83

daryl

Jorge_Merlino · November 23, 2009, 5:50pm

Thank you for your response but I have just found a couple of bugs in my patch. I’m sending a new patch here with those bugs corrected. Sorry for the inconvenience.
packetFilter.patch.zip (5107 Bytes)

Nate_Putnam1 · November 25, 2009, 6:01am

Thanks for the patch!

Daryl,

Thanks for filing. I’ll work with Gato to get this checked in. He’ll have to do the proof reading

guus · January 2, 2010, 5:18pm

Sadly, this patch does not work. The provided JSPs in the monitoring packetFilter plugin do not compile.

Jorge_Merlino · January 2, 2010, 5:56pm

That’s strange. I made the patch against the plugin in the OF 3.6.4 sources. Are you trying with this same sources?

Could you tell me which files do not compile so I can check with my sources? I have this plugin workin in production with this patch.

Also I don’t understand the reference to the monitoring plugin. I did not intend to make any modifications to this plugin, only to the packet filter. Maybe I made a mistake when creating the patch file and included unintended modifications to other plugins.

Regards

Jorge

guus · January 2, 2010, 6:08pm

Disregard the reference to the Monitoring plugin. I’ve been working on that yesterday, I think it is haunting me.

I have applied your patch to the current trunk of Openfire, and recompiled Openfire and the monitoring plugin. During the part of the buildfile where the JSPs get compiled, things break. I have rolled back the changes, and things work fine again.