powered by Jive Software

Should discoInfo with NodeVerHash == null be stored


#1

During porting of smack 4.3.0 for aTalk, I realize that smack EntityCapsManager Implementation does not cache discoInfo with (NodeVerHash == null). Any reason for doing this?

While tracing aTalk, following disco’s are without nvh; aTalk actually stores these discoInfo that are without nvh in its local cache. No sure if this is a problem.

08-25 10:27:58.979 3805-4690/org.atalk.android D/SMACK: SENT (0): <iq to='conference.atalk.org' id='hxbOc-121' type='get'><query xmlns='http://jabber.org/protocol/disco#info'></query></iq>
08-25 10:27:58.992 3805-4691/org.atalk.android D/SMACK: RECV (0): <iq xml:lang='en' to='swordfish@atalk.org/atalk' from='conference.atalk.org' type='result' id='hxbOc-121'><query xmlns='http://jabber.org/protocol/disco#info'><identity name='Chatrooms' type='text' category='conference'/><feature var='http://jabber.org/protocol/disco#info'/><feature var='http://jabber.org/protocol/disco#items'/><feature var='jabber:iq:register'/><feature var='http://jabber.org/protocol/muc'/><feature var='vcard-temp'/><feature var='urn:xmpp:mucsub:0'/><feature var='http://jabber.org/protocol/muc#unique'/><feature var='http://jabber.org/protocol/rsm'/><feature var='urn:xmpp:mam:tmp'/><feature var='urn:xmpp:mam:0'/><feature var='urn:xmpp:mam:1'/><feature var='urn:xmpp:mam:2'/><x type='result' xmlns='jabber:x:data'><field var='FORM_TYPE' type='hidden'><value>http://jabber.org/network/serverinfo</value></field></x></query></iq>
08-25 10:27:58.996 3805-6231/org.atalk.android W/aTalk: [834] impl.protocol.jabber.ScServiceDiscoveryManager.discoverInfo().323 Add discoverInfo with null nvh for: conference.atalk.org

08-25 10:27:58.999 3805-4690/org.atalk.android D/SMACK: SENT (0): <iq to='irc.atalk.org' id='hxbOc-123' type='get'><query xmlns='http://jabber.org/protocol/disco#info'></query></iq><r xmlns='urn:xmpp:sm:3'/>
08-25 10:27:59.078 3805-4691/org.atalk.android D/SMACK: RECV (0): <iq xml:lang='en' to='swordfish@atalk.org/atalk' from='irc.atalk.org' type='result' id='hxbOc-123'><query xmlns='http://jabber.org/protocol/disco#info'><identity name='IRC Transport' type='irc' category='conference'/><feature var='http://jabber.org/protocol/disco#info'/><feature var='http://jabber.org/protocol/disco#items'/><feature var='http://jabber.org/protocol/muc'/><feature var='jabber:iq:register'/><feature var='vcard-temp'/><feature var='http://jabber.org/protocol/commands'/><x type='result' xmlns='jabber:x:data'><field var='FORM_TYPE' type='hidden'><value>http://jabber.org/network/serverinfo</value></field></x></query></iq>
08-25 10:27:59.081 3805-6231/org.atalk.android W/aTalk: [834] impl.protocol.jabber.ScServiceDiscoveryManager.discoverInfo().323 Add discoverInfo with null nvh for: irc.atalk.org

08-25 10:27:59.084 3805-4690/org.atalk.android D/SMACK: SENT (0): <a xmlns='urn:xmpp:sm:3' h='35'/><iq to='proxy.atalk.org' id='hxbOc-125' type='get'><query xmlns='http://jabber.org/protocol/disco#info'></query></iq>
08-25 10:27:59.248 3805-4691/org.atalk.android D/SMACK: RECV (0): <iq xml:lang='en' to='swordfish@atalk.org/atalk' from='proxy.atalk.org' type='result' id='hxbOc-125'><query xmlns='http://jabber.org/protocol/disco#info'><identity name='File Transfer Proxy' type='bytestreams' category='proxy'/><feature var='http://jabber.org/protocol/disco#info'/><feature var='http://jabber.org/protocol/disco#items'/><feature var='vcard-temp'/><feature var='http://jabber.org/protocol/bytestreams'/><x type='result' xmlns='jabber:x:data'><field var='FORM_TYPE' type='hidden'><value>http://jabber.org/network/serverinfo</value></field></x></query></iq>
08-25 10:27:59.252 3805-6231/org.atalk.android W/aTalk: [834] impl.protocol.jabber.ScServiceDiscoveryManager.discoverInfo().323 Add discoverInfo with null nvh for: proxy.atalk.org

08-25 10:27:59.254 3805-4690/org.atalk.android D/SMACK: SENT (0): <a xmlns='urn:xmpp:sm:3' h='36'/><iq to='pubsub.atalk.org' id='hxbOc-127' type='get'><query xmlns='http://jabber.org/protocol/disco#info'></query></iq>
08-25 10:27:59.405 3805-4691/org.atalk.android D/SMACK: RECV (0): <iq xml:lang='en' to='swordfish@atalk.org/atalk' from='pubsub.atalk.org' type='result' id='hxbOc-127'><query xmlns='http://jabber.org/protocol/disco#info'><identity name='Publish-Subscribe' type='service' category='pubsub'/><feature var='http://jabber.org/protocol/disco#info'/><feature var='http://jabber.org/protocol/disco#items'/><feature var='http://jabber.org/protocol/pubsub'/><feature var='http://jabber.org/protocol/commands'/><feature var='vcard-temp'/><feature var='http://jabber.org/protocol/pubsub#access-authorize'/><feature var='http://jabber.org/protocol/pubsub#access-open'/><feature var='http://jabber.org/protocol/pubsub#access-presence'/><feature var='http://jabber.org/protocol/pubsub#access-whitelist'/><feature var='http://jabber.org/protocol/pubsub#auto-create'/><feature var='http://jabber.org/protocol/pubsub#auto-subscribe'/><feature var='http://jabber.org/protocol/pubsub#collections'/><feature var='http://jabber.org/protocol/pubsub#config-node'/><feature var='http://jabber.org/protocol/pubsub#create-and-configure'/><feature var='http://jabber.org/protocol/pubsub#create-nodes'/><feature var='http://jabber.org/protocol/pubsub#delete-items'/><feature var='http://jabber.org/protocol/pubsub#delete-nodes'/><feature var='http://jabber.org/protocol/pubsub#filtered-notifications'/><feature var='http://jabber.org/protocol/pubsub#get-pending'/><feature var='http://jabber.org/protocol/pubsub#instant-nodes'/><feature var='http://jabber.org/protocol/pubsub#item-ids'/><feature var='http://jabber.org/protocol/pubsub#last-published'/><feature var='http://jabber.org/protocol/pubsub#manage-subscriptions'/><feature var='http://jabber.org/protocol/pubsub#member-affiliation'/><feature var='http://jabber.org/protocol/pubsub#modify-affiliations'/><feature var='http://jabber.org/protocol/pubsub#multi-items'/><feature var='http://jabber.org/protocol/pubsub#outcast-affiliation'/><feature var='http://jabber.org/protocol/pubsub#persistent-items'/><feature var='http://jabber.org/protocol/pubsub#presence-notifications'/><feature var='http://jabber.org/protocol/pubsub#presence-subscribe'/><feature var='http://jabber.org/protocol/pubsub#publish'/><feature var='http://jabber.org/protocol/pubsub#publish-only-affiliation'/><feature var='http://jabber.org/protocol/pubsub#publish-options'/><feature var='http://jabber.org/protocol/pubsub#publisher-affiliation'/><feature var='http://jabber.org/protocol/pubsub#purge-nodes'/><feature var='http://jabber.org/protocol/pubsub#retract-items'/><feature var='http://jabber.org/protocol/pubsub#retrieve-affiliations'/><feature var='http://jabber.org/protocol/pubsub#retrieve-default'/><feature var='http://jabber.org/protocol/pubsub#retrieve-items'/><feature var='http://jabber.org/protocol/pubsub#retrieve-subscriptions'/><feature var='http://jabber.org/protocol/rsm'/><feature var='http://jabber.org/protocol/pubsub#shim'/><feature var='http://jabber.org/protocol/pubsub#subscribe'/><feature var='http://jabber.org/protocol/pubsub#subscription-notifications'/><x type='result' xmlns='jabber:x:data'><field var='FORM_TYPE' type='hidden'><value>http://jabber.org/network/serverinfo</value></field></x></query></iq>
08-25 10:27:59.408 3805-4691/org.atalk.android D/SMACK: RECV (0): <r xmlns='urn:xmpp:sm:3'/>
pubsub.atalk.org