powered by Jive Software

Some issues related to the XEP-0045 (Multi-User Chat)

I was inspecting the MUC classes in the OF project and noticed some things that are different from XEP-0045 and some things that would be nice to be implemented.

1. Delayed messages

Accordingly to the section 7.2.14 Discussion History, “The ‘from’ attribute MUST be set to the JID of the room itself” (from attribute of tag).

However, in the MUCRoomHistory class, the ‘from’ attribute is set with the user JID (if the room.canAnyoneDiscoverJID() then from={real user JID} else from={muc user JID}).

An example from this section is

Thrice the brinded cat hath mew'd.

Futhermore, if the room.canAnyoneDiscoverJID(), in other words, “If the room is non-anonymous, the service MAY include an Extended Stanza Addressing (XEP-0033) [16] element that notes the original full JID of the sender by means of the “ofrom” address type:”

Thrice the brinded cat hath mew'd.

2. Notification of Configuration Changes

If the user changes the room configuration, the occupants are not notified about that.

In the XEP-0045 section 10.2.1 Notification of Configuration Changes, we have “A room MUST send notification to all occupants when the room configuration changes in a way that has an impact on the privacy or security profile of the room.”

It should be implemented in the IQOwnerHandler.processConfigurationForm() method, returning messages with one of these status: 170, 171, 172, 173 or 104.

I’m implementing these issues. ASAP I will submit in my fork branch.

1 Like

I commited in the branch https://github.com/aberenguel/Openfire/tree/muc-issues

I’ll be glad if you can comment my changes